Commit Graph

9644 Commits (5d645e1d3ccb6aac3ae04fa81d88e1c7660f80b0)

Author SHA1 Message Date
Andrew Obuchowicz 8c7c008831 chore: remove che.workspace.server.ping_success_threshold & che.workspace.server.ping_interval_milliseconds properties
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 2ae602980c chore: remove che.workspace.probe_pool_size property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 5a932eeba6 chore: remove che.workspace.pool.type, che.workspace.pool.exact_size, che.workspace.pool.cores_multiplier properties
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 9f9dce1bf5 chore: remove che.workspace.auto_start property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 80d1f4e06d chore: remove che.workspace.pod.tolerations_json property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 5283270814 chore: remove che.workspace.pod.node_selector property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 9c6a43c0f9 chore: remove che.workspace.activity_check_scheduler_period_s, che.workspace.activity_check_scheduler_delay_s, che.workspace.activity_cleanup_scheduler_period_s, che.workspace.activity_cleanup_scheduler_initial_delay_s properties
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 454cdd7c6b chore: remove che.workspace.sidecar.image_pull_policy property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 5360484f28 chore: remove che.infra.kubernetes.workspace_start_timeout_min property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz ee3f2b9911 chore: remove che.workspace.http_proxy, che.workspace.https_proxy, che.workspace.no_proxy properties
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz 0c3afb1f22 chore: remove che.workspace.logs.root_dir property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Andrew Obuchowicz f3700dba05 chore: remove che.workspace.projects.storage property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-11-02 10:38:35 +01:00
Igor Vinokur b7f8fea502
fix: Fix gitlab url validation (#372)
Check if a user namespace PAT secret is present, even if the given URL doesn't match the predefined patterns.
Fix the getPatternMatcherByUrl() function as gitlabUrlPatterns.isEmpty() condition is impossible.
Fix the git credentials secret initialisation when a PAT secret is already present.
2022-10-21 09:34:03 +03:00
Igor Vinokur a6faefa953
fix: fix resolving Gitlab raw url (#371)
Partially reverts 5aa763a in order to fix the Gitlab OAuth flow.
The rawFileUrl method uses the API request now. If the request is passed without token it works for public repos, unlike the previous raw file request which fails for private projects, even with the Authorisation header.
2022-10-19 17:59:17 +03:00
Igor Vinokur acc57c7788
chore: Apply maximum allowed expiryDays for the bitbucket server token request (#370)
* chore: Apply maximum allowed expiryDays for the bitbucket server token request

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

* fixup! chore: Apply maximum allowed expiryDays for the bitbucket server token request

* fixup! chore: Apply maximum allowed expiryDays for the bitbucket server token request

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
2022-10-14 12:29:58 -03:00
Mykhailo Kuznietsov bc4ec10c23 chore: Bump to 7.56.0-SNAPSHOT in main
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
2022-10-12 16:11:49 +02:00
che-bot 304ef32c26
chore: Update from ubi8-minimal:8.6-902.1661794353 to ubi8-minimal:8.6-941 (#367)
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
2022-10-12 08:56:33 -03:00
Igor Vinokur f9e002b880
chore: Improve the bitbucket-server Url pattern (#368)
Improve the bitbucket server Url pattern to support url from project repositories and from the bitbucket page that includes branch reference.
2022-10-11 16:35:17 +03:00
Anatolii Bazko d4e29dfe61
Merge pull request #355 from eclipse-che/CRW-3328
feat: Delegate only needed roles to user in his namespace
2022-10-06 11:54:28 +03:00
Anatolii Bazko dfe5b372c2 Fix import
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
2022-10-06 09:57:38 +03:00
Igor Vinokur 5aa763aab3
chore: Fix Gitlab raw file location url (#363)
Rework the Gitlab raw file url function to return a public raw file url instead of an API request.
Trim the gitlabEndpoint if it ends with /
2022-10-03 09:52:14 +03:00
che-bot 6350fa9ab4
chore: Bump to 7.55.0-SNAPSHOT in main (#358)
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
2022-09-29 17:06:33 +03:00
Igor Vinokur 2e269aae64
chore: Rework the bitbucket raw file location url (#362)
Rework the rawFileLocation() function to return a file url, which is available for public, without an authentication. This allows to use a factory from a public bitbucket repo without the bitbucket OAuth configuration.
2022-09-28 15:34:39 +03:00
Igor Vinokur 40598a0e8b
fix: Allign the GitHub raw file location Url with subdomain isolation option (#361)
Inject the che.integration.github.disable_subdomain_isolation env variable property to handle the subdomain isolation GitHub option while returning the GitHub raw file location.
2022-09-28 09:59:19 +03:00
Igor Vinokur a8623992b6
chore: Allign the /token/refresh/ factory API method (#359)
Fix the /token/refresh/ factory API method by picking out the hostname from the url parameter and passing it to personalAccessTokenManager.getAndStore(hostname) instead of the entire factory url
2022-09-26 09:05:04 +03:00
Jana Vrbkova b02dc2e9b7
language review of che.properties and multiuser.properties (#315)
* language review

* peer review suggestions

* Update che.properties

* implemented feedback

* Update che.properties

add missing `che.infra.kubernetes.server_strategy=multi-host`; update text

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
2022-09-21 11:45:16 -03:00
Igor Vinokur 64fd318bb5
chore: Refactore the factory flow to pick out the authentication logic to a separate API method (#356)
Refactor the factory flow and isolate the place where the OAuth token is fetched and stored to the git secret.
Create a new API method with the isolated flow.
The API method is going to be used for the token verification step when a factory is restarted from dashboard.
2022-09-20 15:04:24 +03:00
Florent BENOIT 126762ba16 chore: remove benoitf as code owner 2022-09-16 14:19:10 +02:00
Anatolii Bazko 4994821ba9 feat: Delegate only needed roles to user in his namespace
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
2022-09-14 16:56:19 +03:00
Vitaliy Gulyy 7c7b9ef52e
Merge pull request #351 from eclipse-che/che-21635
fix: Allow to get files from git repository if file name starts with dot
2022-09-09 19:26:55 +03:00
Vitaliy Gulyy feb63108be fix: Allow to get files from git repository if file name starts with dot
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
2022-09-09 17:39:20 +03:00
che-bot 77926d847d
chore: Update from ubi8-minimal:8.6-902 to ubi8-minimal:8.6-902.1661794353 (#348)
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
2022-09-08 09:50:06 -04:00
Igor Vinokur c2a2d09194
chore: Support configuring the GitHub OAuth endpoint (#350)
Currently the GitHub OAuth provider is hardcoded to https://github.com endpoint. In order to support Github Enterprise Server, the endpoint of the GitHub OAuth provider is configurable by the oauth secret.
2022-09-08 14:51:12 +03:00
Mykhailo Kuznietsov 9f72001242 chore: Bump to 7.54.0-SNAPSHOT in main
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
2022-08-31 15:11:43 +02:00
Igor Vinokur 86799d5fe9
fix: Fix url resolving in the bitbucket api client (#346)
Fix a bug where url is not resolved correctly if a server url has path segments. URI.create(https://server-url/path-segment).resolve(/second-path) returns https://server-url/second-path, so the path-segment is ignored. See for more details.

Add a trailing / to the server url and make the rest api segments reletive to fix the problem.
2022-08-30 14:53:15 +03:00
Andrew Obuchowicz c4d272b140 Remove usage of placeholder variables that were previously injected, cleanup comments
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz 971acbd7a2 Remove che.infra.kubernetes.pvc.jobs.image, che.infra.kubernetes.pvc.jobs.image.pull_policy, che.infra.kubernetes.pvc.jobs.memorylimit properties and some PVC-related classes
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz d9870829fa Remove che.infra.kubernetes.async.storage.image, che.infra.kubernetes.async.storage.shutdown_timeout_min, che.infra.kubernetes.async.storage.shutdown_check_period_min properties and some PVC-related classes
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz f107c5066c Get che-server to deploy without errors from PVC properties removal
Remove usage of WorkspaceVolumeStrategy, unbind workspacePVCCleaner in KubernetesInfraModule

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz dfb69017b7 remove che.infra.kubernetes.pvc.strategy property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz f84cea3ddd remove che.infra.kubernetes.pvc.enabled property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz 2091b4a02b remove che.workspace.projects.storage.default.size property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz d11c28325e remove che.infra.kubernetes.pvc.wait_bound property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz 2791c8cfa2 remove che.infra.kubernetes.pvc.precreate_subpaths property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz debae71fc7 remove che.infra.kubernetes.pvc.storage_class_name property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz 5286f28c51 remove che.infra.kubernetes.pvc.access_mode property
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Andrew Obuchowicz 18c12861a0 remove che.infra.kubernetes.pvc.name and che.infra.kubernetes.pvc.quantity properties
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2022-08-17 18:32:07 +02:00
Igor Vinokur 97b7431bda
chore: Add GitHub get pull request API method (#341)
Add GitHub getPullRequest API method
Use the API method insted of reading html content of a pull-request page when creating a factory from GitHub url.
2022-08-15 15:17:38 +03:00
Igor Vinokur bd9cd9db44
chore: Apply authentication status in the callback url (#338)
When processing an authentication callback request set additional error query patameter to the callback url.
How it works:
1. User creates a factory form dashboard.
2. Dasboard requests che-server factory API with no error param in the request url. See https://github.com/eclipse-che/che-dashboard/pull/599
3. Che-server create factory API parses the url for the error param. No error query param means `skipAuthentication=false`. Authentication in progress.
74eb0a333d/wsmaster/che-core-api-factory-github/src/main/java/org/eclipse/che/api/factory/server/github/GithubFactoryParametersResolver.java (L104-L106)
4. GitHub shows the authentication page. If User rejects the authentication, authentication status is set to `access_denied`.
5. The error status is added to the redirect url as a query param.
74eb0a333d/wsmaster/che-core-api-auth/src/main/java/org/eclipse/che/security/oauth/EmbeddedOAuthAPI.java (L85-L93)
6. Dasboard is loaded from the redirect url. Dashboard requests the che-server to create factory by an api request with the error status query param from the redirect url.
e2849d9d21/packages/dashboard-frontend/src/containers/Loader/Factory/Steps/FetchDevfile/index.tsx (L208-L213)
7. Che-server create factory API parses the url for the status param. If `skipAuthentication=true` the authentication flow is skiped and factory creation progress goes further. If `skipAuthentication=false` factory is created in a regular way.
74eb0a333d/wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/scm/AuthorizingFileContentProvider.java (L70-L81)
2022-08-11 17:14:30 +03:00
Mykhailo Kuznietsov c57d3b04a9 chore: Bump to 7.53.0-SNAPSHOT in main
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
2022-08-11 15:58:39 +02:00