seg_yinzy
/
che-server
mirror of https://github.com/eclipse-che/che-server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove che.infra.kubernetes.pvc.precreate_subpaths property 

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
pull/344/head
Andrew Obuchowicz 2022-07-27 17:44:08 -04:00 committed by Ilya Buziuk
parent debae71fc7
commit 2791c8cfa2
4 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
View File

@ -407,14 +407,6 @@ che.infra.kubernetes.pvc.enabled=true
# Existing PVC will be used or a new one will be created if it doesn't exist.
che.infra.kubernetes.pvc.strategy=common
# Defines whether to run a job that creates workspace's subpath directories in persistent volume for the `common` strategy before launching a workspace.
# Necessary in some versions of {orch-name} as workspace subpath volume mounts are created with root permissions,
# and therefore cannot be modified by workspaces running as a user (presents an error importing projects into a workspace in {prod-short}).
# The default is `true`, but should be set to `false` if the version of {orch-name} creates subdirectories with user permissions.
# See: link:https://github.com/kubernetes/kubernetes/issues/41638[subPath in volumeMount is not writable for non-root users #41638]
# the {prod-short} Operator that this property has effect only if the `common` PVC strategy used.
che.infra.kubernetes.pvc.precreate_subpaths=true
# Pod that is launched when performing persistent volume claim maintenance jobs on OpenShift

1
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che_aliases.properties
View File

@ -19,7 +19,6 @@ che.infra.kubernetes.bootstrapper.installer_timeout_sec=che.infra.openshift.boot
che.infra.kubernetes.bootstrapper.server_check_period_sec=che.infra.openshift.bootstrapper.server_check_period_sec
che.infra.kubernetes.pvc.enabled=che.infra.openshift.pvc.enabled
che.infra.kubernetes.pvc.strategy=che.infra.openshift.pvc.strategy
che.infra.kubernetes.pvc.precreate_subpaths=che.infra.openshift.pvc.precreate_subpaths
che.infra.kubernetes.pvc.jobs.image=che.infra.openshift.pvc.jobs.image
che.infra.kubernetes.pvc.jobs.memorylimit=che.infra.openshift.pvc.jobs.memorylimit
che.infra.kubernetes.tls_enabled=che.infra.openshift.tls_enabled

3
infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/pvc/CommonPVCStrategy.java
View File

@ -105,7 +105,6 @@ public class CommonPVCStrategy implements WorkspaceVolumesStrategy {
@Inject
public CommonPVCStrategy(
@Named("che.infra.kubernetes.pvc.precreate_subpaths") boolean preCreateDirs,
@Named("che.infra.kubernetes.pvc.wait_bound") boolean waitBound,
PVCSubPathHelper pvcSubPathHelper,
KubernetesNamespaceFactory factory,
@ -117,7 +116,7 @@ public class CommonPVCStrategy implements WorkspaceVolumesStrategy {
this.configuredPVCName = "test";
this.pvcQuantity = "test";
this.pvcAccessMode = "TEST";
this.preCreateDirs = preCreateDirs;
this.preCreateDirs = true;
this.pvcStorageClassName = "TEST";
this.waitBound = waitBound;
this.pvcSubPathHelper = pvcSubPathHelper;

2
infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/pvc/PerWorkspacePVCStrategy.java
View File

@ -52,7 +52,6 @@ public class PerWorkspacePVCStrategy extends CommonPVCStrategy {
@Inject
public PerWorkspacePVCStrategy(
@Named("che.infra.kubernetes.pvc.precreate_subpaths") boolean preCreateDirs,
@Named("che.infra.kubernetes.pvc.wait_bound") boolean waitBound,
PVCSubPathHelper pvcSubPathHelper,
KubernetesNamespaceFactory factory,
@ -62,7 +61,6 @@ public class PerWorkspacePVCStrategy extends CommonPVCStrategy {
SubPathPrefixes subpathPrefixes,
WorkspaceManager workspaceManager) {
super(
preCreateDirs,
waitBound,
pvcSubPathHelper,
factory,