less_than is not working with for example “5.9.1” and “5.10.0”, 5.9.0 being said to be a greater version
bash-4.3# version_lt "5.9.0" "5.10.1"
—> 0
bash-4.3# less_than "5.9.0" "5.10.1"
—> 1
bash-4.3# less_than "5.6" "5.8"
—> 0
Change-Id: I33417f012c193416bfb746df125c19e92a868b4e
note: version_lt is a less and equals method, so we need to exclude the condition : tag == base version
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
The build scripts have been modified to generate images of the format $ORGANIZATION/$PREFIX-$NAME:$TAG. The default organization is eclipse, the default tag is nightly, and the default prefix is che. You can proivde --organization:<org>, --prefix:<prefix>, or --tag:<tag> on the command line to customize the images that are generated.
There is a new build-che.sh script which builds the minimum set of images to generate a new Che server, the CLI, and unit tests for these custom image names. If you build the CLI image, we overwrite /dockerfiles/cli/version/$TAG/images file to include the customized names that have been provided before this image is built, so the registry within the Docker image is accurate.
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
* allow using args for start command in cmd_upgrade
for now there is no way to pass any arg to start command on upgrade, but on our prod we must skip preflight checks because they will not work due to closed ports on firewall. those changes allow using `upgrade --skip-backup --skip:preflight`
* Fix#1682 : Improve UX of graceful shutdown message
- base scripts : catch error code of action lifecycle and return it
- cha-lib : return error code based on http error code
- display better message when auth is required
- skip graceful mode when repo is mounted
Change-Id: I1ad021426444b5b4d880df518512e53ef4828336
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
It avoids to give the option when it was not added on the original command line and that the sub action is not requiring a terminal
Also now print a warning if a terminal is given without interactive mode
Change-Id: Ib76480ccf4320748a4fbc4704773b9337048ef61
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
* Fix#3980 by reworking how integration tests are launched
- We used OS path mounted into container path (it makes issues as on Windows we don’t have these paths)
- Now use /dockerfiles path inside the container
- add skip check for nightlies or it was downloading new images while testing the current nightly
- add —rm for cleaning containers at the end of docker run
- introduce of some asserts instead of custom checks
- Fix windows issue (like path with spaces)
- Fix teardown of che start tests
Change-Id: I352d7c475796df641c1e34f461c55a76c897922d
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Eugene Ivantsov