When adding a new git remote with URL that starts with spaces it will be wrongly displayed in the remotes list. Adding trim() to remote URL resolves this problem.
Changed path parameters in getPair and removePair methods in SshService to query parameters to be able to receive parameter 'name' that contains slashes.
Added host name validation in 'Generate SSH key' dialog.
Refactors workspace bootstrapping code:
Addition of projects volumes to ws-machines and
applying of agents moved to infrastructure provisioner.
It can be overwritten in any implementation of Che and
will be responsible for providing all infrastructure needed for Che implementation functioning.
Allow to configure environment network driver.
Allow to add Agents from the code instead of special files.
These agents can override agents configured in files if identifiers are equal.
Adds possibility to host agents binaries from CHE master.
Reworks agents in a way when they can be downloaded from CHE master if they are not found on FS.
Adds workspace ID to internal representation of environment to allow to use it for internal purposes of machine bootstrapping.
Renames some properties.
Refactors AgentConfigApplier to encapsulate additional code that was used with this class before.
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
Change the text displayed to connect with SSH to a machine
- display correct user to use
- display ssh private key if any
- display che ssh command
Change-Id: I9a5e3aeeb8c3b7fa8503976ac190d5a8a2e4c4b1
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
In che Owner of a machine or namespace of a workspace is the same than the user-id
ssh service is using user-id while username is given so there is never a match
It fixes it by asking userManager the userId.
Change-Id: I30a20a52ffc3149a8f732edeb8ab86db827c9d91
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
* Fixes#2728: Respect user settings when sending formatting options to LS
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
* Remove spaces in empty line
* CHE-2059 : Each time a workspace is created, register/associate ssh key
Change-Id: Ifddfe5398cffd1af31aa93beb5d0674b29270f4f
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
The goal of this refactoring is to set correct type of HTTP methods in GitService. Now almost all HTTP methods in this service are POST methods, but there are methods that are used to get some content, so they should be marked as GET method. Also I had to change such methods to receive query parameters instead of body.
Implemented parameter objects to use them instead of using DTO as parameter in GitConnection methods.
* Get projects after workspace has been already initialized
This commit also includes API reorganization. Move client service implementations from the core-api to the core-app. Code cleanup. Removed dependency to the javax.inject from the core-api to avoid duplicate using @Inject annotation from the com.google.inject and javax.inject. (Client side uses only com.google.inject.Inject annotation)
Created two components:
WsAgentInitializer - which is responsible to initialize workspace component on the client side. Component consumes developer machine object at startup stage.
WsAgentMessageBusProvider - which is responsible to initialize message bus after workspace has been initialized.
API movements:
OAuthServiceClient was moved from the org.eclipse.che.ide.api.auth to the org.eclipse.ide.api.oauth
* Move WsAgentInitizalizer to the core-app
* Add @Override annotation
* Add @Override annotation
* Remove @Singleton annotation
* Remove @Singleton annotation
* Revert javax.inject.Inject annotation
* Update codebase due to changes in the master branch
Vitalii Parfonov