* prevent workspace restarting if user intentionally stopped it
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
* fixup! prevent workspace restarting if user intentionally stopped it
* fixed handling of error status of a workspace after it has been started.
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
* workaround for devserver proxy to replace header 'origin' with target host
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
* use string interpolation instead of concatenation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
* Reuse the Dashboard Keycloak instance in IDE frames when possible
This avoids one or 2 authentication flows between the real IDE loading,
and decrease the overall IDE loading process by 5 seconds or more.
(5-6 seconds out of 10-12s in my case)
Signed-off-by: David Festal <dfestal@redhat.com>
Currently in Che there are still a number of requirements in upstream that are not required by the OIDC specification, so that Che still cannot be used with a number of OIDC compliant providers.
For example, in order to have Che working with the [`node-oidc-provider`](https://github.com/panva/node-oidc-provider), the following changes were necessary:
- Remove the requirement to have the email as a claim in the JWT access
token: this is not required the specification and is not supported by a
number of OIDC providers. Normally, the Id token contains such claims.
So now if the email is not in the JWT token the first time the user connects to Che, ten the email is retrieved from the OIDC provider through its `user-profile` endpoint.
- Explicitely specify the the `openid email profile` scope when requesting the access token. Because OIDC providers, when answering to the `userInfo` endpoint, are expected to return claims that corresponds to the scopes of the access token. So if an access token has the `openid` scope only, the `userinfo` might return no claim at all (according to the specification).
Until now it was working since keycloak allows adding claims to the returned tokens anyway.
- Allow supporting fixed redirect Uris: most OIDC providers support having a list of redirect URIs to come back to after the authorization step. But these authorized Uris don't necessarily support wildcards or prefix. Che doesn't support this currently, and these changes introduce 2 fixed callback HTML pages that redirect to the Dashboard / IDE URL of the final page we want to come back to after authentication. This makes Che compatible with more OIDC providers
We introduced a new boolean property to enable / disable fixed redirect URLs:
`che.keycloak.use_fixed_redirect_urls`
whose default value is `false`
- The previous points required some light changes in the Keycloak Javascript adapter file, that we will submit as a PR to the Keycloak project. I, the meantime the `OIDCKeycloak.js` file is still used, but has been updated to be now based on the `keycloak.js` file of the last `4.5.0-final` Keycloak release. This will make this Keycloak PR easier to get accepted.
Please keep in mind that this version upgrade only impacts the alternate OIDC provider case: when using a real Keycloak server, Che *always uses the `keycloak.js` file provided by the Keycloak server*.
Signed-off-by: David Festal <dfestal@redhat.com>
Allow switching to an alternate OIDC provider (provided that it emits access tokens as JWT tokens).
This is the implementation required in upstream Che, for issues
redhat-developer/rh-che#502 and
redhat-developer/rh-che#525
Signed-off-by: David Festal <dfestal@redhat.com>
* CHE-9024: fix ability to start a workspace from Dashboard
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
* fixup! CHE-9024: fix ability to start a workspace from Dashboard
Mykola Morhun