* CHE-2059 : Each time a workspace is created, register/associate ssh key
Change-Id: Ifddfe5398cffd1af31aa93beb5d0674b29270f4f
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
The goal of this refactoring is to set correct type of HTTP methods in GitService. Now almost all HTTP methods in this service are POST methods, but there are methods that are used to get some content, so they should be marked as GET method. Also I had to change such methods to receive query parameters instead of body.
Implemented parameter objects to use them instead of using DTO as parameter in GitConnection methods.
* Get projects after workspace has been already initialized
This commit also includes API reorganization. Move client service implementations from the core-api to the core-app. Code cleanup. Removed dependency to the javax.inject from the core-api to avoid duplicate using @Inject annotation from the com.google.inject and javax.inject. (Client side uses only com.google.inject.Inject annotation)
Created two components:
WsAgentInitializer - which is responsible to initialize workspace component on the client side. Component consumes developer machine object at startup stage.
WsAgentMessageBusProvider - which is responsible to initialize message bus after workspace has been initialized.
API movements:
OAuthServiceClient was moved from the org.eclipse.che.ide.api.auth to the org.eclipse.ide.api.oauth
* Move WsAgentInitizalizer to the core-app
* Add @Override annotation
* Add @Override annotation
* Remove @Singleton annotation
* Remove @Singleton annotation
* Revert javax.inject.Inject annotation
* Update codebase due to changes in the master branch
* CODENVY-932 Stopped IDE should provide clear state and options to the user
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
* CODENVY-932 Stopped IDE should provide clear state and options to the user
* CODENVY-932 Stopped IDE should provide clear state and options to the user
* CODENVY-932 Stopped IDE should provide clear state and options to the user
If the hover message consists of multiple MarkedStrings then they should
be joined via double newline, so they are rendered as seperate Markdown
paragraphs.
If a MarkedString has the `language` property provided then it should be
rendered as a Markdown code block.
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
For example now that sh is default one, previous user commands may fail. If the commands are launched on sh, then /bin/sh will need to be defined as shell invoker
Change-Id: I19e2065bfd9e6ee93a5d899cb67cd5b9ece76f62
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
When I enable Closure Compiler and set GWT JavaScript compiler output style to DETAILED mode
by providing the following configuration of gwt-maven-plugin:
<configuration>
<modules>
<module>org.eclipse.che.ide.IDE</module>
</modules>
<style>DETAILED</style>
<enableClosureCompiler>true</enableClosureCompiler>
</configuration>
I get the following compilation error:
[INFO] Compiling 4 permutations
[INFO] Compiling permutation 0...
[ERROR] error optimizing:JSC_VAR_ARGUMENTS_SHADOWED_ERROR. Shadowing "arguments" is not allowed at org/eclipse/che/plugin/maven/client/command/MavenCommandModel.java line 25 : 0
[INFO] [ERROR] Unexpected internal compiler error
[INFO] java.lang.RuntimeException: Shadowing "arguments" is not allowed
[INFO] at com.google.gwt.dev.js.ClosureJsRunner.compile(ClosureJsRunner.java:207)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler$PermutationCompiler.generateJavaScriptCode(JavaToJavaScriptCompiler.java:524)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler$PermutationCompiler.compilePermutation(JavaToJavaScriptCompiler.java:347)
[INFO] at com.google.gwt.dev.jjs.MonolithicJavaToJavaScriptCompiler.compilePermutation(MonolithicJavaToJavaScriptCompiler.java:296)
[INFO] at com.google.gwt.dev.jjs.UnifiedAst.compilePermutation(UnifiedAst.java:143)
[INFO] at com.google.gwt.dev.CompilePerms.compile(CompilePerms.java:197)
[INFO] at com.google.gwt.dev.ThreadedPermutationWorkerFactory$ThreadedPermutationWorker.compile(ThreadedPermutationWorkerFactory.java:50)
[INFO] at com.google.gwt.dev.PermutationWorkerFactory$Manager$WorkerThread.run(PermutationWorkerFactory.java:74)
[INFO] at java.lang.Thread.run(Thread.java:745)
[INFO] [ERROR] Unrecoverable exception, shutting down
[INFO] com.google.gwt.core.ext.UnableToCompleteException: (see previous log entries)
[INFO] at com.google.gwt.dev.javac.CompilationProblemReporter.logAndTranslateException(CompilationProblemReporter.java:112)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler$PermutationCompiler.compilePermutation(JavaToJavaScriptCompiler.java:363)
[INFO] at com.google.gwt.dev.jjs.MonolithicJavaToJavaScriptCompiler.compilePermutation(MonolithicJavaToJavaScriptCompiler.java:296)
[INFO] at com.google.gwt.dev.jjs.UnifiedAst.compilePermutation(UnifiedAst.java:143)
[INFO] at com.google.gwt.dev.CompilePerms.compile(CompilePerms.java:197)
[INFO] at com.google.gwt.dev.ThreadedPermutationWorkerFactory$ThreadedPermutationWorker.compile(ThreadedPermutationWorkerFactory.java:50)
[INFO] at com.google.gwt.dev.PermutationWorkerFactory$Manager$WorkerThread.run(PermutationWorkerFactory.java:74)
[INFO] at java.lang.Thread.run(Thread.java:745)
[INFO] [ERROR] Not all permutation were compiled , completed (0/4)
It means that using 'arguments' as a name of a method parameter is forbidden by Google Closure Compiler because, it seems, that it's reserved for internal using here:
https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/SyntacticScopeCreator.java#L38
Allow to override /bin/sh by a "shell" attribute in commands
Change-Id: I19b95868c44f473552a153e29d1ba41abcc19aef
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Client command framework improvements
1. Introduced contextual commands.
2. Added ${explorer.current.file.parent.path} macro.
3. Cleaned up unused resources.
4. Refactored code in order to simplify it and made it more clear and understandable:
- simplified a way of providing new command types;
- command types api moved to ide-api to avoid unnecessary dependency on machine extension;
- command management extracted from EditCommandsPresenter to the separate facade - CommandManager. So EditCommandsPresenter now doesn't perform several http requests manipulating with commands but only one;
- refactored code related to the obsolete terminology CommandPropertyValueProvider -> Macro;
- macro can provide its description (it will be really useful for showing it in UI);
- macros processing separated from the command execution and extracted to the separate component MacroProcessor since it's used not only for the commands but in debug configurations for example.
The VS Code's JSON language server expects a 'json/schemaAssociations'
notification to associate JSON files to JSON schemas. This activates
capabilities like code completion, validation and hover without the need
to add a '$schema' key.
This change implements an extension of the JsonBasedLanguageServer that
registers as ServerInitializerObserver and sends the
'json/schemaAssociations' notification on the 'onServerInitialized'
event.
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
* Fixes#2592: Filter code completion proposals from language server
Implements filtering based on the existing FuzzyMatches used for the
GoToSymbolAction.
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
* Add empty line at end of file.
* Fixes#2437: Shift remaining ranges when applying multi-edit formatting
A formatting request to a language server may result in a list of
multiple text edits. The ranges of all these text edits are based on the
yet unmodified document. Che applies the edits to the document one by
one. If the inserted text has a different length than the replaced text
then the ranges of the remaining edits become invalid and they must be
shifted appropriately.
This patch shifts the ranges as necessary. To achieve this, it first
converts the ranges based on lines and characters to linear ranges,
which are easier for shifting.
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
* Simplify the shifting logic
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
* Reworked: just applying the text edits backwards is enough
Igor Vinokur