seg_yinzy
/
che-server
mirror of https://github.com/eclipse-che/che-server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improving 'if' checks 

Signed-off-by: <alextrentton@gmail.com>
6.19.x
Alex Ve 2016-04-12 16:52:05 +03:00
parent 8929284ac2
commit f8fddf78b2
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
core/che-core-api-dto/src/main/java/org/eclipse/che/dto/generator/DtoImpl.java
View File

@ -232,7 +232,7 @@ abstract class DtoImpl {
}
String methodName = method.getName();
if ((methodName.startsWith("get") || methodName.startsWith("is")) && method.getParameterTypes().length == 0) {
if (methodName.startsWith("is") && methodName.length() > 2) {
if (methodName.length() > 2 && methodName.startsWith("is")) {
return method.getReturnType() == Boolean.class || method.getReturnType() == boolean.class;
}
return methodName.length() > 3;
@ -247,12 +247,11 @@ abstract class DtoImpl {
/** Tests whether or not a given return type is a number primitive or its wrapper type. */
protected static boolean isNumber(Class<?> returnType) {
final Class<?>[] numericTypes = {int.class, long.class, short.class, float.class, double.class, byte.class,
Integer.class, Long.class, Short.class, Float.class, Double.class, Byte.class};
for (Class<?> standardPrimitive : numericTypes) {
if (returnType.equals(standardPrimitive)) {
return true;
}
if (null != returnType && (Number.class.isAssignableFrom(returnType)
|| int.class.equals(returnType) || long.class.equals(returnType)
|| short.class.equals(returnType) || float.class.equals(returnType)
|| double.class.equals(returnType) || byte.class.equals(returnType))) {
return true;
}
return false;
}