From a00f92d9af5d0bd1b39b90574a0696c65d2105de Mon Sep 17 00:00:00 2001 From: Anatolii Bazko Date: Fri, 1 Dec 2023 14:25:19 +0100 Subject: [PATCH] Address remarks Signed-off-by: Anatolii Bazko --- .../kubernetes/authorization/AuthorizationException.java | 2 +- .../kubernetes/namespace/KubernetesNamespaceFactory.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/authorization/AuthorizationException.java b/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/authorization/AuthorizationException.java index 3b3eb0e087..eb08dbe73b 100644 --- a/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/authorization/AuthorizationException.java +++ b/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/authorization/AuthorizationException.java @@ -15,7 +15,7 @@ import org.eclipse.che.api.workspace.server.spi.InfrastructureException; import org.eclipse.che.api.workspace.server.spi.RuntimeInfrastructure; /** - * An exception thrown by {@link RuntimeInfrastructure} and related components. Indicates that an + * An exception thrown by {@link RuntimeInfrastructure} and related components. Indicates that a * user is not authorized to use Che. * * @author Anatolii Bazko diff --git a/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java b/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java index 3f7122bd86..319d1b8770 100644 --- a/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java +++ b/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java @@ -585,15 +585,15 @@ public class KubernetesNamespaceFactory { } } - protected void validateAuthorization(String namespaceName, String userName) + protected void validateAuthorization(String namespaceName, String username) throws InfrastructureException { - if (!authorizationChecker.isAuthorized(userName)) { + if (!authorizationChecker.isAuthorized(username)) { try { permissionsCleaner.cleanUp(namespaceName); } catch (InfrastructureException | KubernetesClientException e) { LOG.error( "Failed to clean up permissions for user '{}' in namespace '{}'. Cause: {}", - userName, + username, namespaceName, e.getMessage(), e); @@ -602,7 +602,7 @@ public class KubernetesNamespaceFactory { throw new AuthorizationException( format( "User '%s' is not authorized to create a project. Please contact your system administrator.", - userName)); + username)); } }