seg_yinzy
/
che-server
mirror of https://github.com/eclipse-che/che-server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore(github): Update the pull request template to match new definition of done on PR 

https://github.com/eclipse/che/issues/17486

Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
7.20.x
Florent Benoit 2020-08-13 10:56:11 +02:00 committed by Florent BENOIT
parent d0b034e18c
commit 9c5d915d88
1 changed files with 30 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,24 +1,43 @@
<!-- Please review the following before submitting a PR:
Che's Contributing Guide: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md
Pull Request Policy: https://github.com/eclipse/che/wiki/Development-Workflow#pull-requests
COMMITTERS: please include labels on each PR. Labels are listed here: https://github.com/eclipse/che/wiki/Labels but at a minimum you should include `kind/..` and `Dev Open Pull Request Status` labels.
-->
### What does this PR do?
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
### What issues does this PR fix or reference?
<!-- #### Changelog -->
<!-- The changelog will be pulled from the PR's title.
Please provide a clear and meaningful title to the PR and don't include issue number -->
<!-- Please include any related issue from eclipse che repository (or from another issue tracker).
Include link to other pull requests like documentation PR from [the docs repo](https://github.com/eclipse/che-docs)
-->
#### Release Notes
<!-- markdown to be included in marketing announcement - N/A for bugs -->
### How to test this PR?
<!-- Please explain for example :
- The test platform (openshift, kubernetes, minikube, CodeReady Container, docker-desktop, etc)
- Installation method: chectl / che-operator
- steps to reproduce
-->
#### Docs PR
<!-- Please add a matching PR to [the docs repo](https://github.com/eclipse/che-docs) and link that PR to this issue.
Both will be merged at the same time. -->
### PR Checklist
[As the author of this Pull Request I made sure that:](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#pull-request-template-and-its-checklist)
- [ ] [The Eclipse Contributor Agreement is valid](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#the-eclipse-contributor-agreement-is-valid)
- [ ] [Code produced is complete](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-produced-is-complete)
- [ ] [Code builds without errors](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-builds-without-errors)
- [ ] [Tests are covering the bugfix](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#tests-are-covering-the-bugfix)
- [ ] [The repository devfile is up to date and works](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#the-repository-devfile-is-up-to-date-and-works)
- [ ] [Sections `What issues does this PR fix or reference` and `How to test this PR` completed](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#sections-what-issues-does-this-pr-fix-or-reference-and-how-to-test-this-pr-completed)
- [ ] [Relevant user documentation updated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#relevant-contributing-documentation-updated)
- [ ] [Relevant contributing documentation updated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#relevant-contributing-documentation-updated)
- [ ] [CI/CD changes implemented, documented and communicated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#cicd-changes-implemented-documented-and-communicated)
### Reviewers
Reviewers, please comment how you tested the PR when approving it.