diff --git a/wsmaster/che-core-api-factory-github/src/main/java/org/eclipse/che/api/factory/server/github/GithubApiClient.java b/wsmaster/che-core-api-factory-github/src/main/java/org/eclipse/che/api/factory/server/github/GithubApiClient.java index b503da409d..8e9a4f5a50 100644 --- a/wsmaster/che-core-api-factory-github/src/main/java/org/eclipse/che/api/factory/server/github/GithubApiClient.java +++ b/wsmaster/che-core-api-factory-github/src/main/java/org/eclipse/che/api/factory/server/github/GithubApiClient.java @@ -228,7 +228,7 @@ public class GithubApiClient { String result = CharStreams.toString(new InputStreamReader(response.body(), Charsets.UTF_8)); GithubUser user = OBJECT_MAPPER.readValue(result, GithubUser.class); - return Pair.of(user.getName(), scopes); + return Pair.of(user.getLogin(), scopes); } catch (IOException e) { throw new UncheckedIOException(e); } diff --git a/wsmaster/che-core-api-factory-github/src/test/java/org/eclipse/che/api/factory/server/github/GithubApiClientTest.java b/wsmaster/che-core-api-factory-github/src/test/java/org/eclipse/che/api/factory/server/github/GithubApiClientTest.java index ebeaca3ff5..6e9e775d5f 100644 --- a/wsmaster/che-core-api-factory-github/src/test/java/org/eclipse/che/api/factory/server/github/GithubApiClientTest.java +++ b/wsmaster/che-core-api-factory-github/src/test/java/org/eclipse/che/api/factory/server/github/GithubApiClientTest.java @@ -36,6 +36,7 @@ import java.lang.reflect.Field; import org.eclipse.che.api.factory.server.scm.exception.ScmBadRequestException; import org.eclipse.che.api.factory.server.scm.exception.ScmCommunicationException; import org.eclipse.che.api.factory.server.scm.exception.ScmItemNotFoundException; +import org.eclipse.che.commons.lang.Pair; import org.mockito.testng.MockitoTestNGListener; import org.testng.annotations.AfterMethod; import org.testng.annotations.BeforeMethod; @@ -165,11 +166,13 @@ public class GithubApiClientTest { .withHeader(GithubApiClient.GITHUB_OAUTH_SCOPES_HEADER, "repo, user:email") .withBodyFile("github/rest/user/response.json"))); - String[] scopes = client.getTokenScopes("token1").second; + Pair pair = client.getTokenScopes("token1"); + String[] scopes = pair.second; String[] expectedScopes = {"repo", "user:email"}; assertNotNull(scopes, "GitHub API should have returned a non-null scope array"); assertEqualsNoOrder( scopes, expectedScopes, "Returned scope array does not match expected values"); + assertEquals(pair.first, "github-user"); } @Test