From 5006a1040b4e112e3c6324b0207a7a6429018c95 Mon Sep 17 00:00:00 2001 From: Igor Vinokur Date: Tue, 12 Jul 2016 11:55:53 +0300 Subject: [PATCH] CODENVY-570: Do not log InvalidRecipeException We should not log exception if failed to create machine on InvalidRecipeException --- .../org/eclipse/che/api/machine/server/MachineManager.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/MachineManager.java b/wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/MachineManager.java index 399e6f97c6..ae11fec063 100644 --- a/wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/MachineManager.java +++ b/wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/MachineManager.java @@ -31,6 +31,7 @@ import org.eclipse.che.api.core.util.LineConsumer; import org.eclipse.che.api.core.util.WebsocketLineConsumer; import org.eclipse.che.api.machine.server.dao.SnapshotDao; import org.eclipse.che.api.machine.server.event.InstanceStateEvent; +import org.eclipse.che.api.machine.server.exception.InvalidRecipeException; import org.eclipse.che.api.machine.server.exception.MachineException; import org.eclipse.che.api.machine.server.exception.SnapshotException; import org.eclipse.che.api.machine.server.exception.SourceNotFoundException; @@ -262,7 +263,9 @@ public class MachineManager { machine, machineLogger); } catch (MachineException | NotFoundException e) { - LOG.error(e.getLocalizedMessage(), e); + if (!(e.getCause() instanceof InvalidRecipeException)) { + LOG.error(e.getLocalizedMessage(), e); + } // todo what should we do in that case? } })),