seg_yinzy
/
che-server
mirror of https://github.com/eclipse-che/che-server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CHE-2344: Fixes repetitive saving snapshot of workspace (#2413) 

Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
6.19.x
Alexander Garagatyi 2016-09-12 16:59:16 +03:00 committed by GitHub
parent 27dd4852ae
commit 4612ca5fd0
16 changed files with 382 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
core/che-core-api-model/src/main/java/org/eclipse/che/api/core/model/machine/MachineConfig.java
View File

@ -18,7 +18,6 @@ import java.util.Map;
/**
* @author gazarenkov
*/
@Deprecated
public interface MachineConfig {
/**

1
core/che-core-api-model/src/main/java/org/eclipse/che/api/core/model/machine/MachineLimits.java
View File

@ -15,7 +15,6 @@ package org.eclipse.che.api.core.model.machine;
*
* @author Alexander Garagatyi
*/
@Deprecated
public interface MachineLimits {
/** Get memory size (in megabytes) that is allocated for starting machine. */
int getRam();

1
core/che-core-api-model/src/main/java/org/eclipse/che/api/core/model/machine/MachineSource.java
View File

@ -13,7 +13,6 @@ package org.eclipse.che.api.core.model.machine;
/**
* @author gazarenkov
*/
@Deprecated
public interface MachineSource {
/**

1
core/che-core-api-model/src/main/java/org/eclipse/che/api/core/model/machine/ServerConf.java
View File

@ -17,7 +17,6 @@ import org.eclipse.che.commons.annotation.Nullable;
*
* @author Alexander Garagatyi
*/
@Deprecated
public interface ServerConf {
/**
* Reference to this server.

1
plugins/plugin-docker/che-plugin-docker-machine/src/main/java/org/eclipse/che/plugin/docker/machine/DockerMachineSource.java
View File

@ -25,7 +25,6 @@ import static org.eclipse.che.plugin.docker.machine.DockerInstanceProvider.DOCKE
*
* @author Florent Benoit
*/
@Deprecated
public class DockerMachineSource extends MachineSourceImpl {
/**

3
plugins/plugin-docker/che-plugin-docker-machine/src/main/java/org/eclipse/che/plugin/docker/machine/ext/provider/DockerExtConfBindingProvider.java
View File

@ -48,8 +48,7 @@ public class DockerExtConfBindingProvider implements Provider<String> {
}
File extConfDir = new File(localConfDir, PLUGIN_CONF);
if (!extConfDir.isDirectory()) {
LOG.warn("DockerExtConfBindingProvider",
String.format("%s set to the %s but it must be directory not file", CheBootstrap.CHE_LOCAL_CONF_DIR, localConfDir));
LOG.warn("{} set to the {} but it must be directory not file", CheBootstrap.CHE_LOCAL_CONF_DIR, localConfDir);
return null;
}

1
wsmaster/che-core-api-machine-shared/src/main/java/org/eclipse/che/api/machine/shared/dto/MachineConfigDto.java
View File

@ -25,7 +25,6 @@ import static org.eclipse.che.api.core.factory.FactoryParameter.Obligation.OPTIO
/**
* @author Alexander Garagatyi
*/
@Deprecated
@DTO
public interface MachineConfigDto extends MachineConfig, Hyperlinks {
@Override

1
wsmaster/che-core-api-machine-shared/src/main/java/org/eclipse/che/api/machine/shared/dto/MachineLimitsDto.java
View File

@ -16,7 +16,6 @@ import org.eclipse.che.dto.shared.DTO;
/**
* @author Alexander Garagatyi
*/
@Deprecated
@DTO
public interface MachineLimitsDto extends MachineLimits {
MachineLimitsDto withRam(int memorySizeMB);

1
wsmaster/che-core-api-machine-shared/src/main/java/org/eclipse/che/api/machine/shared/dto/MachineSourceDto.java
View File

@ -20,7 +20,6 @@ import static org.eclipse.che.api.core.factory.FactoryParameter.Obligation.OPTIO
/**
* @author Alexander Garagatyi
*/
@Deprecated
@DTO
public interface MachineSourceDto extends MachineSource {
@Override

1
wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/model/impl/MachineConfigImpl.java
View File

@ -27,7 +27,6 @@ import java.util.stream.Collectors;
*
* @author Eugene Voevodin
*/
@Deprecated
public class MachineConfigImpl implements MachineConfig {
public static MachineConfigImplBuilder builder() {

1
wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/model/impl/MachineLimitsImpl.java
View File

@ -15,7 +15,6 @@ import org.eclipse.che.api.core.model.machine.MachineLimits;
/**
* @author Alexander Garagatyi
*/
@Deprecated
public class MachineLimitsImpl implements MachineLimits {
private final int memory;

1
wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/model/impl/MachineSourceImpl.java
View File

@ -23,7 +23,6 @@ import static java.util.Objects.hash;
*
* @author Eugene Voevodin
*/
@Deprecated
public class MachineSourceImpl implements MachineSource {
private String type;

12
wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/environment/server/CheEnvironmentEngine.java
View File

@ -469,17 +469,15 @@ public class CheEnvironmentEngine {
*
* @param snapshot
* description of snapshot that should be removed
* @throws NotFoundException
* if snapshot is not found
* @throws ServerException
* if error occurs on snapshot removal
*/
public void removeSnapshot(SnapshotImpl snapshot) throws ServerException {
public void removeSnapshot(SnapshotImpl snapshot) throws ServerException, NotFoundException {
final String instanceType = snapshot.getType();
try {
final InstanceProvider instanceProvider = machineInstanceProviders.getProvider(instanceType);
instanceProvider.removeInstanceSnapshot(snapshot.getMachineSource());
} catch (NotFoundException e) {
throw new ServerException(e.getLocalizedMessage(), e);
}
final InstanceProvider instanceProvider = machineInstanceProviders.getProvider(instanceType);
instanceProvider.removeInstanceSnapshot(snapshot.getMachineSource());
}
private void initializeEnvironment(String workspaceId,

54
wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceManager.java
View File

@ -732,16 +732,9 @@ public class WorkspaceManager {
.withWorkspaceId(workspaceId));
String devMachineSnapshotFailMessage = null;
for (MachineImpl machine : runtime.getMachines()) {
try {
SnapshotImpl snapshot = runtimes.saveMachine(namespace,
workspaceId,
machine.getId());
snapshotDao.saveSnapshot(snapshot);
} catch (ApiException apiEx) {
if (machine.getConfig().isDev()) {
devMachineSnapshotFailMessage = apiEx.getLocalizedMessage();
}
LOG.error(apiEx.getLocalizedMessage(), apiEx);
String error = replaceSnapshot(machine, namespace);
if (error != null && machine.getConfig().isDev()) {
devMachineSnapshotFailMessage = error;
}
}
if (devMachineSnapshotFailMessage != null) {
@ -757,6 +750,47 @@ public class WorkspaceManager {
return devMachineSnapshotFailMessage == null;
}
private String replaceSnapshot(MachineImpl machine, String namespace) {
try {
try {
SnapshotImpl oldSnapshot = snapshotDao.getSnapshot(machine.getWorkspaceId(),
machine.getEnvName(),
machine.getConfig().getName());
snapshotDao.removeSnapshot(oldSnapshot.getId());
runtimes.removeSnapshot(oldSnapshot);
} catch (NotFoundException ignored) {
// Do nothing if no snapshot found
}
SnapshotImpl snapshot = null;
try {
snapshot = runtimes.saveMachine(namespace,
machine.getWorkspaceId(),
machine.getId());
snapshotDao.saveSnapshot(snapshot);
} catch (ApiException e) {
if (snapshot != null) {
try {
runtimes.removeSnapshot(snapshot);
} catch (ApiException e1) {
LOG.error(format("Snapshot removal failed. Snapshot: %s. Error: %s",
snapshot,
e1.getLocalizedMessage()),
e1);
}
}
throw e;
}
return null;
} catch (ApiException apiEx) {
LOG.error("Snapshot creation failed. Error: " + apiEx.getLocalizedMessage(), apiEx);
return apiEx.getLocalizedMessage();
}
}
@VisibleForTesting
void checkWorkspaceIsRunning(WorkspaceImpl workspace, String operation) throws ConflictException {
if (workspace.getStatus() != RUNNING) {

4
wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceRuntimes.java
View File

@ -490,10 +490,12 @@ public class WorkspaceRuntimes {
*
* @param snapshot
* description of snapshot that should be removed
* @throws NotFoundException
* if snapshot is not found
* @throws ServerException
* if error occurs
*/
public void removeSnapshot(SnapshotImpl snapshot) throws ServerException {
public void removeSnapshot(SnapshotImpl snapshot) throws ServerException, NotFoundException {
environmentEngine.removeSnapshot(snapshot);
}

341
wsmaster/che-core-api-workspace/src/test/java/org/eclipse/che/api/workspace/server/WorkspaceManagerTest.java
View File

@ -12,6 +12,7 @@ package org.eclipse.che.api.workspace.server;
import org.eclipse.che.api.core.ConflictException;
import org.eclipse.che.api.core.NotFoundException;
import org.eclipse.che.api.core.ServerException;
import org.eclipse.che.api.core.model.machine.MachineStatus;
import org.eclipse.che.api.core.model.workspace.WorkspaceConfig;
import org.eclipse.che.api.core.model.workspace.WorkspaceStatus;
@ -34,6 +35,7 @@ import org.eclipse.che.api.workspace.server.model.impl.WorkspaceImpl;
import org.eclipse.che.api.workspace.server.model.impl.WorkspaceRuntimeImpl;
import org.eclipse.che.api.workspace.server.spi.WorkspaceDao;
import org.eclipse.che.api.workspace.shared.Constants;
import org.eclipse.che.api.workspace.shared.dto.event.WorkspaceStatusEvent;
import org.eclipse.che.commons.env.EnvironmentContext;
import org.eclipse.che.commons.subject.Subject;
import org.eclipse.che.commons.subject.SubjectImpl;
@ -48,6 +50,7 @@ import org.testng.annotations.Test;
import java.util.HashMap;
import java.util.List;
import java.util.UUID;
import static com.google.common.base.Strings.isNullOrEmpty;
import static java.util.Arrays.asList;
@ -59,6 +62,10 @@ import static org.eclipse.che.api.core.model.workspace.WorkspaceStatus.STOPPED;
import static org.eclipse.che.api.workspace.server.WorkspaceManager.CREATED_ATTRIBUTE_NAME;
import static org.eclipse.che.api.workspace.server.WorkspaceManager.UPDATED_ATTRIBUTE_NAME;
import static org.eclipse.che.api.workspace.shared.Constants.AUTO_RESTORE_FROM_SNAPSHOT;
import static org.eclipse.che.api.workspace.shared.dto.event.WorkspaceStatusEvent.EventType.SNAPSHOT_CREATED;
import static org.eclipse.che.api.workspace.shared.dto.event.WorkspaceStatusEvent.EventType.SNAPSHOT_CREATING;
import static org.eclipse.che.api.workspace.shared.dto.event.WorkspaceStatusEvent.EventType.SNAPSHOT_CREATION_ERROR;
import static org.eclipse.che.dto.server.DtoFactory.newDto;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyBoolean;
import static org.mockito.Matchers.anyObject;
@ -527,13 +534,16 @@ public class WorkspaceManagerTest {
@Test
public void shouldBeAbleToStopWorkspace() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
final RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
// when
workspaceManager.stopWorkspace(workspace.getId());
// then
verify(runtimes, timeout(2000)).stop(workspace.getId());
assertNotNull(workspace.getAttributes().get(UPDATED_ATTRIBUTE_NAME));
}
@ -545,6 +555,11 @@ public class WorkspaceManagerTest {
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
final RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
workspaceManager.stopWorkspace(workspace.getId());
@ -618,6 +633,7 @@ public class WorkspaceManagerTest {
@Test
public void shouldCreateWorkspaceSnapshotUsingDefaultValueForAutoRestore() throws Exception {
// given
workspaceManager = spy(new WorkspaceManager(workspaceDao,
runtimes,
eventService,
@ -628,9 +644,16 @@ public class WorkspaceManagerTest {
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
final RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
// then
workspaceManager.stopWorkspace(workspace.getId());
// then
verify(workspaceManager, timeout(2000)).createSnapshotSync(workspace.getRuntime(), workspace.getNamespace(), workspace.getId());
verify(runtimes, timeout(2000)).stop(any());
}
@ -750,7 +773,7 @@ public class WorkspaceManagerTest {
when(workspaceMock.getStatus()).thenReturn(RUNNING);
when(workspaceMock.getRuntime()).thenReturn(wsRuntimeMock);
when(wsRuntimeMock.getActiveEnv()).thenReturn(testActiveEnv);
MachineConfigImpl machineConfig = createMachine().getConfig();
MachineConfigImpl machineConfig = createMachine(testWsId, testActiveEnv, false).getConfig();
// when
workspaceManager.startMachine(machineConfig, testWsId);
@ -766,7 +789,7 @@ public class WorkspaceManagerTest {
WorkspaceImpl workspaceMock = mock(WorkspaceImpl.class);
doReturn(workspaceMock).when(workspaceManager).getWorkspace(testWsId);
when(workspaceMock.getStatus()).thenReturn(STARTING);
MachineConfigImpl machineConfig = createMachine().getConfig();
MachineConfigImpl machineConfig = createMachine(testWsId, "env1", false).getConfig();
// when
workspaceManager.startMachine(machineConfig, testWsId);
@ -774,11 +797,16 @@ public class WorkspaceManagerTest {
@Test
public void shouldBeAbleToCreateSnapshot() throws Exception {
// then
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
// when
workspaceManager.createSnapshot(workspace.getId());
@ -792,7 +820,7 @@ public class WorkspaceManagerTest {
@Test(expectedExceptions = ConflictException.class,
expectedExceptionsMessageRegExp = "Could not .* the workspace '.*' because its status is '.*'.")
public void shouldNotCreateSnapshotIfWorkspaceIsNotRunning() throws Exception {
// then
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, STARTING);
@ -802,6 +830,295 @@ public class WorkspaceManagerTest {
workspaceManager.createSnapshot(workspace.getId());
}
@Test
public void shouldSnapshotAllMachinesInWs() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(runtimes, timeout(1_000).times(2)).saveMachine(eq(workspace.getNamespace()),
eq(workspace.getId()),
anyString());
verify(snapshotDao, timeout(1_000).times(2)).saveSnapshot(any(SnapshotImpl.class));
}
@Test
public void shouldSendEventOnStartSnapshotSaving() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(eventService, timeout(1_000)).publish(eq(newDto(WorkspaceStatusEvent.class)
.withEventType(SNAPSHOT_CREATING)
.withWorkspaceId(workspace.getId())));
}
@Test
public void shouldSendEventOnSuccessfulSnapshotSaving() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(eventService, timeout(1_000)).publish(eq(newDto(WorkspaceStatusEvent.class)
.withEventType(SNAPSHOT_CREATED)
.withWorkspaceId(workspace.getId())));
}
@Test
public void shouldSendSnapshotSavingFailedEventIfDevMachineSnapshotSavingFailed() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
for (MachineImpl machine : descriptor.getRuntime().getMachines()) {
if (machine.getConfig().isDev()) {
when(runtimes.saveMachine(workspace.getNamespace(), workspace.getId(), machine.getId()))
.thenThrow(new ServerException("test error"));
}
}
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(eventService, timeout(1_000)).publish(eq(newDto(WorkspaceStatusEvent.class)
.withEventType(SNAPSHOT_CREATION_ERROR)
.withWorkspaceId(workspace.getId())
.withError("test error")));
}
@Test
public void shouldNotSendSnapshotSavingFailedEventIfNonDevMachineSnapshotSavingFailed() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
for (MachineImpl machine : descriptor.getRuntime().getMachines()) {
if (!machine.getConfig().isDev()) {
when(runtimes.saveMachine(workspace.getNamespace(), workspace.getId(), machine.getId()))
.thenThrow(new ServerException("test error"));
}
}
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(eventService, timeout(1_000)).publish(eq(newDto(WorkspaceStatusEvent.class)
.withEventType(SNAPSHOT_CREATED)
.withWorkspaceId(workspace.getId())));
}
@Test
public void shouldReturnFalseOnFailureSnapshotSavingIfDevMachineSavingFailed() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
for (MachineImpl machine : descriptor.getRuntime().getMachines()) {
if (machine.getConfig().isDev()) {
when(runtimes.saveMachine(workspace.getNamespace(), workspace.getId(), machine.getId()))
.thenThrow(new ServerException("test error"));
}
}
// when
boolean snapshotSavingStatus = workspaceManager.createSnapshotSync(
new WorkspaceRuntimeImpl(descriptor.getRuntime()), workspace.getNamespace(), workspace.getId());
// then
assertFalse(snapshotSavingStatus);
}
@Test
public void shouldReturnTrueOnSuccessfulSavingSnapshotsForSeveralMachines() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
// when
boolean snapshotSavingStatus = workspaceManager.createSnapshotSync(
new WorkspaceRuntimeImpl(descriptor.getRuntime()), workspace.getNamespace(), workspace.getId());
// then
assertTrue(snapshotSavingStatus);
// ensure that multiple machines were saved
verify(snapshotDao, timeout(1_000).atLeast(2)).saveSnapshot(any(SnapshotImpl.class));
}
@Test
public void shouldReturnTrueOnSavingSnapshotsForSeveralMachinesWhenNonDevMachineSavingFailed() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
for (MachineImpl machine : descriptor.getRuntime().getMachines()) {
if (!machine.getConfig().isDev()) {
when(runtimes.saveMachine(workspace.getNamespace(), workspace.getId(), machine.getId()))
.thenThrow(new ServerException("test error"));
}
}
// when
boolean snapshotSavingStatus = workspaceManager.createSnapshotSync(
new WorkspaceRuntimeImpl(descriptor.getRuntime()), workspace.getNamespace(), workspace.getId());
// then
assertTrue(snapshotSavingStatus);
}
@Test
public void shouldRemoveRuntimeSnapshotIfSavingSnapshotInDaoFails() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
doThrow(new SnapshotException("test error")).when(snapshotDao).saveSnapshot(any(SnapshotImpl.class));
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(runtimes, timeout(1_000).times(2)).removeSnapshot(any(SnapshotImpl.class));
}
@Test
public void shouldIgnoreNotFoundExceptionOnOldSnapshotRemoval1() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
doThrow(new NotFoundException("test error")).when(snapshotDao).removeSnapshot(anyString());
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(workspaceManager, timeout(1_000)).createSnapshotSync(any(WorkspaceRuntimeImpl.class),
eq(workspace.getNamespace()),
eq(workspace.getId()));
}
@Test
public void shouldIgnoreNotFoundExceptionOnOldSnapshotRemoval2() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
SnapshotImpl oldSnapshot = mock(SnapshotImpl.class);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenReturn(oldSnapshot);
doThrow(new NotFoundException("test error")).when(runtimes).removeSnapshot(any(SnapshotImpl.class));
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(workspaceManager, timeout(1_000)).createSnapshotSync(any(WorkspaceRuntimeImpl.class),
eq(workspace.getNamespace()),
eq(workspace.getId()));
}
@Test
public void shouldIgnoreNotFoundExceptionOnOldSnapshotRemoval3() throws Exception {
// given
final WorkspaceImpl workspace = workspaceManager.createWorkspace(createConfig(), "user123", "account");
when(workspaceDao.get(workspace.getId())).thenReturn(workspace);
RuntimeDescriptor descriptor = createDescriptor(workspace, RUNNING);
when(runtimes.get(any())).thenReturn(descriptor);
when(snapshotDao.getSnapshot(eq(workspace.getId()),
eq(workspace.getConfig().getDefaultEnv()),
anyString()))
.thenThrow(new NotFoundException("test error"));
// when
workspaceManager.createSnapshot(workspace.getId());
// then
verify(workspaceManager, timeout(1_000)).createSnapshotSync(any(WorkspaceRuntimeImpl.class),
eq(workspace.getNamespace()),
eq(workspace.getId()));
}
@Test
public void shouldBeAbleToStopMachine() throws Exception {
// given
@ -868,9 +1185,9 @@ public class WorkspaceManagerTest {
assertNotNull(environment);
final WorkspaceRuntimeImpl runtime = new WorkspaceRuntimeImpl(workspace.getConfig().getDefaultEnv());
MachineImpl machine = spy(createMachine());
MachineImpl machine = spy(createMachine(workspace.getId(), workspace.getConfig().getDefaultEnv(), true));
runtime.getMachines().add(machine);
MachineImpl machine2 = spy(createMachine());
MachineImpl machine2 = spy(createMachine(workspace.getId(), workspace.getConfig().getDefaultEnv(), false));
runtime.getMachines().add(machine2);
final RuntimeDescriptor descriptor = mock(RuntimeDescriptor.class);
@ -895,20 +1212,20 @@ public class WorkspaceManagerTest {
.build();
}
private MachineImpl createMachine() {
private MachineImpl createMachine(String workspaceId, String envName, boolean isDev) {
return MachineImpl.builder()
.setConfig(MachineConfigImpl.builder()
.setDev(false)
.setName("machineName")
.setDev(isDev)
.setName("machineName" + UUID.randomUUID())
.setSource(new MachineSourceImpl("type").setContent("content"))
.setLimits(new MachineLimitsImpl(1024))
.setType("docker")
.build())
.setId("id")
.setId("id" + UUID.randomUUID())
.setOwner("userName")
.setStatus(MachineStatus.RUNNING)
.setWorkspaceId("wsId")
.setEnvName("envName")
.setWorkspaceId(workspaceId)
.setEnvName(envName)
.setRuntime(new MachineRuntimeInfoImpl(new HashMap<>(),
new HashMap<>(),
new HashMap<>()))