Add promise based getRepository method to the GithubServiceClient

6.19.x
Yevhenii Voevodin 2016-02-26 14:45:31 +02:00
parent 0057a88c8b
commit 211cde5336
2 changed files with 28 additions and 4 deletions

View File

@ -41,9 +41,21 @@ public interface GitHubClientService {
* the repository name.
* @param callback
* callback called when operation is done.
* @deprecated use {@link #getRepository(String, String)}
*/
@Deprecated
void getRepository(@NotNull String user, @NotNull String repository, @NotNull AsyncRequestCallback<GitHubRepository> callback);
/**
* Get given repository information.
*
* @param user
* the owner of the repository.
* @param repository
* the repository name.
*/
Promise<GitHubRepository> getRepository(String user, String repository);
/**
* Get list of available public and private repositories of the authorized user.
*/
@ -105,10 +117,14 @@ public interface GitHubClientService {
/**
* Get a pull request by id for a given repository.
*
* @param owner the owner of the target repository
* @param repository the target repository
* @param pullRequestId the Id of the pull request
* @param callback the callback with either the pull request as argument or null if it doesn't exist
* @param owner
* the owner of the target repository
* @param repository
* the target repository
* @param pullRequestId
* the Id of the pull request
* @param callback
* the callback with either the pull request as argument or null if it doesn't exist
*/
void getPullRequest(@NotNull String owner,
@NotNull String repository,

View File

@ -81,6 +81,14 @@ public class GitHubClientServiceImpl implements GitHubClientService {
asyncRequestFactory.createGetRequest(url).loader(loader).send(callback);
}
@Override
public Promise<GitHubRepository> getRepository(String user, String repository) {
final String url = baseUrl + REPOSITORIES + "/" + user + "/" + repository;
return asyncRequestFactory.createGetRequest(url)
.loader(loader)
.send(dtoUnmarshallerFactory.newUnmarshaller(GitHubRepository.class));
}
/** {@inheritDoc} */
@Override
public Promise<List<GitHubRepository>> getRepositoriesList() {