From 0423215112eb39646278ee18dabc00775b58b2e6 Mon Sep 17 00:00:00 2001 From: xbaran4 Date: Mon, 27 Sep 2021 16:49:23 +0200 Subject: [PATCH] fix: trimed preference name bug Signed-off-by: xbaran4 --- .../configurator/UserPreferencesConfigurator.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/configurator/UserPreferencesConfigurator.java b/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/configurator/UserPreferencesConfigurator.java index 1880b9b20f..fb69ac251b 100644 --- a/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/configurator/UserPreferencesConfigurator.java +++ b/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/configurator/UserPreferencesConfigurator.java @@ -42,7 +42,7 @@ import org.eclipse.che.workspace.infrastructure.kubernetes.namespace.KubernetesN public class UserPreferencesConfigurator implements NamespaceConfigurator { private static final String USER_PREFERENCES_SECRET_NAME = "user-preferences"; private static final String USER_PREFERENCES_SECRET_MOUNT_PATH = "/config/user/preferences"; - private static final int PREFERNCE_NAME_MAX_LENGTH = 253; + private static final int PREFERENCE_NAME_MAX_LENGTH = 253; private final KubernetesNamespaceFactory namespaceFactory; private final KubernetesClientFactory clientFactory; @@ -129,8 +129,7 @@ public class UserPreferencesConfigurator implements NamespaceConfigurator { */ @VisibleForTesting String normalizePreferenceName(String name) { - return name.replaceAll("[^-._a-zA-Z0-9]+", "-") - .replaceAll("-+", "-") - .substring(0, Math.min(name.length(), PREFERNCE_NAME_MAX_LENGTH)); + name = name.replaceAll("[^-._a-zA-Z0-9]+", "-").replaceAll("-+", "-"); + return name.substring(0, Math.min(name.length(), PREFERENCE_NAME_MAX_LENGTH)); } }