seg_yinzy
/
DolphinScheduler
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[ci] Add checkstyle prohibit rule System.out.println (#6778) 

* [ci] Add checkstyle prohibit rule System.out.println

* Correct RegexpSingleline place
refactor-ui
Jiajie Zhong 2021-11-13 16:47:29 +08:00 committed by GitHub
parent cd8205217a
commit 6045728428
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/SnowFlakeUtilsTest.java
View File

@ -17,18 +17,19 @@
package org.apache.dolphinscheduler.common.utils;
import java.util.HashSet;
import org.junit.Assert;
import org.junit.Test;
public class SnowFlakeUtilsTest {
@Test
public void testNextId() {
try {
for (int i = 0; i < 100; i++) {
Thread.sleep(1);
System.out.println(SnowFlakeUtils.getInstance().nextId());
}
} catch (Exception e) {
e.printStackTrace();
public void testNoGenerateDuplicateId() throws SnowFlakeUtils.SnowFlakeException {
HashSet<Long> existsSnowFlakeId = new HashSet<>();
for (int i = 0; i < 100; i++) {
Long currentId = SnowFlakeUtils.getInstance().nextId();
Assert.assertFalse(existsSnowFlakeId.contains(currentId));
existsSnowFlakeId.add(currentId);
}
}
}

1
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/StringTest.java
View File

@ -47,7 +47,6 @@ public class StringTest {
}
}
double during = (System.currentTimeMillis() - start) / 1000.0;
System.out.println(during);
Assert.assertEquals("1_0000000000_0000000001", origin);
}
}

1
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java
View File

@ -671,7 +671,6 @@ public abstract class UpgradeDao {
taskDefinitionLog.setName(name);
taskDefinitionLog.setWorkerGroup(task.get("workerGroup").asText());
long taskCode = SnowFlakeUtils.getInstance().nextId();
// System.out.println(taskCode);
taskDefinitionLog.setCode(taskCode);
taskDefinitionLog.setVersion(Constants.VERSION_FIRST);
taskDefinitionLog.setProjectCode(processDefinition.getProjectCode());

1
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/test/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/hive/HiveDatasourceProcessorTest.java
View File

@ -59,7 +59,6 @@ public class HiveDatasourceProcessorTest {
PowerMockito.when(CommonUtils.getKerberosStartupState()).thenReturn(false);
HiveConnectionParam connectionParams = (HiveConnectionParam) hiveDatasourceProcessor
.createConnectionParams(hiveDataSourceParamDTO);
System.out.println(JSONUtils.toJsonString(connectionParams));
Assert.assertNotNull(connectionParams);
Assert.assertEquals("jdbc:hive2://localhost1:5142,localhost2:5142", connectionParams.getAddress());
}

1
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/test/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/mysql/MysqlDatasourceProcessorTest.java
View File

@ -58,7 +58,6 @@ public class MysqlDatasourceProcessorTest {
PowerMockito.when(PasswordUtils.encodePassword(Mockito.anyString())).thenReturn("test");
MysqlConnectionParam connectionParams = (MysqlConnectionParam) mysqlDatasourceProcessor
.createConnectionParams(mysqlDatasourceParamDTO);
System.out.println(JSONUtils.toJsonString(connectionParams));
Assert.assertEquals("jdbc:mysql://localhost:3306", connectionParams.getAddress());
Assert.assertEquals("jdbc:mysql://localhost:3306/default", connectionParams.getJdbcUrl());
}

1
dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistryClientTest.java
View File

@ -81,7 +81,6 @@ public class WorkerRegistryClientTest {
@Test
public void testRegistry() {
//workerRegistryClient.initWorkRegistry();
// System.out.println(this.workerGroups.iterator());
//Set<String> workerGroups = Sets.newHashSet("127.0.0.1");
//workerRegistryClient.registry();
// workerRegistryClient.handleDeadServer();

2
dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/queue/TaskPriorityQueueImplTest.java
View File

@ -103,9 +103,7 @@ public class TaskPriorityQueueImplTest {
queue.poll(1000, TimeUnit.MILLISECONDS);
queue.poll(1000, TimeUnit.MILLISECONDS);
Assert.assertTrue(queue.size() == 0);
System.out.println(System.currentTimeMillis());
queue.poll(1000, TimeUnit.MILLISECONDS);
System.out.println(System.currentTimeMillis());
}
@Test

5
style/checkstyle.xml
View File

@ -34,6 +34,11 @@
<property name="ignorePattern" value="^ *\* *[^ ]+$"/>
</module>
<module name="RegexpSingleline">
<property name="format" value="System\.out\.println"/>
<property name="message" value="Prohibit invoking System.out.println in source code !"/>
</module>
<module name="TreeWalker">
<module name="OuterTypeFilename">
<property name="severity" value="error"/>